Caching problem on OVH k8s cluster deployment

mael-le-gal · May 21, 2019, 1:06pm

Hello everyone,

I tried to deploy the full binder stack starting from mybinder.org-deploy repository and even if it seems to globally work I still have a small problem.

Indeed the image cacheing doesn’t seem to work. It re-triggered a build everytime.

You can test and reproduce the problem here : https://binder.mybinder.ovh/

The configuration I used for that deployment is available here on my PR : https://github.com/jupyterhub/mybinder.org-deploy/pull/970/files

Does anyone has an idea about what I missed ?

Maël

betatim · May 21, 2019, 4:09pm

The bit of code that checks the image registry for an existing image is called from:

github.com

jupyterhub/binderhub/blob/b7dcc7f1bd7bab26f0a31d8750a136c6d3281ef2/binderhub/builder.py#L272-L274


if self.settings['use_registry']:
    image_manifest = await self.registry.get_image_manifest(*'/'.join(image_name.split('/')[-2:]).split(':', 1))
    image_found = bool(image_manifest)

and the code itself is:

github.com

jupyterhub/binderhub/blob/1835d07222388da2a23765899cd006e6f6462827/binderhub/registry.py#L189


        self.log.warning(
            "No password for docker registry at %s", self.auth_config_url
        )
        return ""


    return (
        base64.b64decode(b64_auth.encode("utf-8")).decode("utf-8").split(":", 1)[1]
    )


@gen.coroutine
def get_image_manifest(self, image, tag):
    client = httpclient.AsyncHTTPClient()
    url = "{}/v2/{}/manifests/{}".format(self.url, image, tag)
    # first, get a token to perform the manifest request
    if self.token_url:
        auth_req = httpclient.HTTPRequest(
            url_concat(self.token_url, {"scope": "repository:{}:pull".format(image)}),
            auth_username=self.username,
            auth_password=self.password,
        )
        auth_resp = yield client.fetch(auth_req)

My guess would be that something with checking the registry isn’t quite right. I think there was an issue previously with how the name that is looked up in the registry is formatted or something. The point being that we have had things break around the registry handling before.

The other thing to double check (maybe even first) is if your BinderHub is indeed configured to use a docker registry.

mael-le-gal · May 23, 2019, 7:36am

Indeed the problem was on my configuration key binderhub.config.BinderHub.image_prefix which need to be in 3 parts separated by / for the cache to work properly.

Example of value that was not working :

(.*)/binder-r2d-f18835fd-

Example of new value that work :

(.*)/binder-ovh/r2d-f18835fd-

Thank’s for your help Tim !
This issue can be close

Topic		Replies	Views
Something up with mybinder.org cache Binder	10	1417	June 21, 2023
Binderhub always tries to build ignoring any prebuilds BinderHub how-to , help-wanted	2	470	March 2, 2021
Building image from latest git repo on spawn JupyterHub how-to	6	393	April 2, 2020
Git repository rebuilds, even though it already exists in container registry BinderHub help-wanted	11	1216	May 5, 2023
Do I have to use a repository with Binderhub? If not, how do I locally run them? Binder	4	1276	August 6, 2021

Caching problem on OVH k8s cluster deployment

Related Topics